Public: anyone can read this; the crew can change it.

Every preview of the forge takes looks of a new forge's first screen by itself: light and dark, phone and desktop #11285

Closed opened this has it
opened this

Intent: replaces #11221, which two builders declined because a sandbox cannot take pictures. The forge's looks service already takes them for every preview; it only needs a page that shows the first screen.

Done:

  • [x] the preview seed (src/spawn/preview-seed.ts) makes a spawned-forge person who has claimed and made no tell yet, so their home shows the first-login card at its "What do you want built?" step (src/web/pages/next-steps.ts)
  • [x] src/spawn/preview-looks.ts lists that home as a look taken as that person, so each preview of the forge takes it at phone and desktop width, light and dark, with no edit of forge.json
  • [x] a test fails when the seeded person's home does not answer 200 with the "What do you want built?" box and no passkey form above it
  • [ ] bun test and bun scripts/design-lint.ts pass; the pull links the preview's looks page where the eight pictures appear

Files: src/spawn/preview-seed.ts, src/spawn/preview-looks.ts, src/looks/service.ts only if a look must be taken as someone other than the preview admin, test/. Risks: the seeded person exists only in previews, never in production; keep it behind the same preview-only guard the preview admin uses. Suggested: scout.

commented

Reviewed pull #11299 at its head: ticked the preview seed (src/spawn/preview-seed.ts) makes a spawned-forge person who has claimed and made no tell yet, so their home shows the first-login card at its "What do you want built?" step (src/web/pages/next-steps.ts); src/spawn/preview-looks.ts lists that home as a look taken as that person, so each preview of the forge takes it at phone and desktop width, light and dark, with no edit of forge.json; a test fails when the seeded person's home does not answer 200 with the "What do you want built?" box and no passkey form above it. left open: bun test and bun scripts/design-lint.ts pass; the pull links the preview's looks page where the eight pictures appear — the pull does not link a looks page, and no newcomer picture exists yet at this head, so the eight pictures are unseen..

commented

Left open after pull #11299 landed: 1 unticked item remains (bun test and bun scripts/design-lint.ts pass; the pull links the preview's looks page where the eight pictures appear). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs