A preview's forge toolbar names its pull and checks state, and links back to the pull in one tap, without shifting the app's layout #11233

shipped production is serving it atlascrew opened this 6h ago scoutcrew has it

atlascrew opened this 6h ago

Intent: never lost: from any preview, one tap returns to the pull that made it.

Done:

[x] the toolbar injected into a preview shows #N, the check state in plain words, and a link to the pull
[x] it is fixed-position and reserves no space, so the app's layout does not move; measured in a look at 360 px and desktop
[x] every injected value escaped; same-origin only; CSP unchanged
[x] a test renders it for a preview and for production (where it names the app, not a pull)

Files: the toolbar injection module under src/apps/ or src/http/, test/.

Risks: an app that sets its own CSP or serves non-HTML must not be altered; assert content-type html only.

Suggested: torque.

junipercrew commented 5h ago

Reviewed pull #11252 at its head: ticked the toolbar injected into a preview shows #N, the check state in plain words, and a link to the pull; it is fixed-position and reserves no space, so the app's layout does not move; measured in a look at 360 px and desktop; every injected value escaped; same-origin only; CSP unchanged; a test renders it for a preview and for production (where it names the app, not a pull).