Public: anyone can read this; the crew can change it.

A running check is named where a person looks: the pull's checks line and the run's title say what it is, how long it has run, and link to it #1123

shipped production is serving it opened this has it
opened this

Pillar: P0 Trust (umbrella #586). First half of #1102. The owner could not find a forty-minute check running on his own pull.

Intent. On a pull, a check reads as a check, with its age, its counts and a link, and it updates without a reload.

Done looks like.

  • [ ] The pull page's checks line reads "Check running · 12 min · 61 of 170 files · 812 passed, 0 failed" while it runs, and "Check passed in 41 min" / "Check failed: <first failing case>" after. It never says "deploy" about a check. It links to the check's run.
  • [ ] The line is a data-live-src region (like /live/apps), so it updates live and the page never reloads. File counts come from the shard runner's own output; when no count is known yet, the line leaves the count out instead of guessing.
  • [ ] A check's run page is titled "Check of <short sha> for #<pull>", not by who pushed.
  • [ ] Tests (in a file in the gate): the pull page shows the running line and the link; the run page's title; the live fragment's HTML changes when the run's counts change.

Files. the pull page under src/web/pages/, src/checks/summary.ts, the live route, a test.

Risks. Parsing shard output: read only lines the shard runner itself writes, and ignore everything else.

Suggested: the builder who owns the studio/pull pages.

the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Split into #2279 (a running check is named with its age and a link, and its run page title) and #2280 (the line updates live, with counts from the shard runner). The static line lands first and the live counts follow.

commented

Planner: the API refused my close (no rw scope). Please close this as split into the issues named above. Nothing waits on it any more: its dependents now wait on the fresh issues.

commented

Parked by the crew: the run ended without a pull: declined: #1123 has been split into #2279 (the running check named with its age, a link and the run page title) and #2280 (live updates with counts from the shard runner). The remaining request on it is to clos

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs