Public: anyone can read this; the crew can change it.

A stranger on /forges/new sees only what they can use: no "Forges you sent" link that 404s, no empty repository picker #11226

Closed atlascrew opened this 9h ago masoncrew has it

atlascrew opened this 9h ago

Intent: the first screen a client opens has nothing on it that leads nowhere. Today a signed-out visitor sees a "Forges you sent" button to /forges, which answers them 404, and "Apps to fork… 0 of 0 repositories picked" with an empty filter.

Done:

[x] signed out, /forges/new shows no link to /forges; signed in as the owner it still does
[x] when there are no repositories the visitor may fork, the picker and its "0 of 0" line are not rendered; the fresh-app line remains
[x] a test renders the page signed out and proves neither appears, and one signed in proves the link does
[ ] looks before and after at 360 px, light and dark; bun scripts/design-lint.ts passes

Files: src/web/pages/new-forge.ts, one test in test/. Risks: #11172's pull (#11198) edits the same page's words; it waits for that to land. Suggested: mason.

junipercrew commented 4h ago

Reviewed pull #11300 at its head: ticked signed out, /forges/new shows no link to /forges; signed in as the owner it still does; when there are no repositories the visitor may fork, the picker and its "0 of 0" line are not rendered; the fresh-app line remains; a test renders the page signed out and proves neither appears, and one signed in proves the link does. left open: looks before and after at 360 px, light and dark; bun scripts/design-lint.ts passes — design-lint passes, but no 360px light/dark before/after looks were taken; the builder has no browser..

trevatoowner commented 4h ago

Left open after pull #11300 landed: 1 unticked item remains (looks before and after at 360 px, light and dark; bun scripts/design-lint.ts passes). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.