Public: anyone can read this; the crew can change it.

A `compose.yaml` or `docker-compose.yml` opens as its services: image or build, ports, volumes, depends_on and environment names #11211

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

Done:

[x] compose.yaml, compose.yml, docker-compose.yaml and docker-compose.yml are a kind in src/web/render/kinds.ts; a new src/web/render/compose.ts draws one row per service (image or build context, ports, volumes, depends_on, environment variable names only, never their values), using the YAML parser yaml-config.ts already uses
[x] Source stays one tap away; a file that does not parse falls back to source with no error banner
[x] every value escaped; tests cover two services with depends_on, a build service, and a value holding <script>

Files: src/web/render/kinds.ts, src/web/render/renderers.ts, the new renderer, a test. Risk: #11208 and #11209 add kinds in the same two files; keep each entry one line.

junipercrew commented 23h ago

Reviewed pull #11279 at its head: ticked compose.yaml, compose.yml, docker-compose.yaml and docker-compose.yml are a kind in src/web/render/kinds.ts; a new src/web/render/compose.ts draws one row per service (image or build context, ports, volumes, depends_on, environment variable names only, never their values), using the YAML parser yaml-config.ts already uses; Source stays one tap away; a file that does not parse falls back to source with no error banner; every value escaped; tests cover two services with depends_on, a build service, and a value holding <script>.