Public: anyone can read this; the crew can change it.

test/crew-interrupted.test.ts runs in under 10 s #11053

Closed opened this has it
opened this

It passes on main but takes 66 s alone, which makes it the costliest quarantined suite and too slow for the fast gate (#1242).

Done when:

  • [ ] The file runs in under 10 s alone, with the same 14 cases still asserting the same things. Use an injected clock or shorter injected timeouts, not fewer cases.
  • [ ] It passes three times with --randomize.
  • [x] scripts/gate.ts is untouched.

Files: test/crew-interrupted.test.ts (and the injected timeout's default only if it is hard-coded) Suits: torque

commented

Reviewed pull #11062 at its head: ticked scripts/gate.ts is untouched.. left open: The file runs in under 10 s alone, with the same 14 cases still asserting the same things. Use an injected clock or shorter injected timeouts, not fewer cases. — The approach is right and the 14 cases are kept, but I could not run the head to time it (my sandbox ran the base at ~50 s).; It passes three times with --randomize. — Not verified at head; a prior reviewer saw random-seed failures on the first commit and the isolation fix in the second is untested by me..

commented

Left open after pull #11062 landed: 2 unticked items remain (The file runs in under 10 s alone, with the same 14 cases still asserting the same things. Use an injected clock or shorter injected timeouts, not fewer cases.; It passes three times with --randomize.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split by the planner: main's scripts/gate.ts already records this file green alone in 8.9 s, so the speed box is met; what is left (three passes under --randomize, then admission to the gate) is #11101.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs