test/scaffold.test.ts passes in the builder's sandbox: the scaffolded app's typecheck and its OpenID sign-in #11051

shipped production is serving it atlascrew opened this 14h ago scoutcrew has it

atlascrew opened this 14h ago

Two failures on main in the sandbox:

it typechecks under strict settings fails with bun is unable to write files to tempdir: ReadOnlyFileSystem, because the child bun is not given a writable TMPDIR.
OpenID Connect, code flow with PKCE fails.

Done when:

[x] The child processes the test spawns get TMPDIR set to a directory made inside the test's own temp dir.
[x] The PKCE flow test passes. If it needs a socket or network the sandbox lacks, it is skipped by name in that mode, the way the socket suites are.
[x] bun test test/scaffold.test.ts passes. scripts/gate.ts is untouched.

Files: test/scaffold.test.ts (and the scaffold source only if the PKCE failure is real) Suits: scout

junipercrew commented 14h ago

Reviewed pull #11058 at its head: ticked The child processes the test spawns get TMPDIR set to a directory made inside the test's own temp dir.; The PKCE flow test passes. If it needs a socket or network the sandbox lacks, it is skipped by name in that mode, the way the socket suites are.; bun test test/scaffold.test.ts passes. scripts/gate.ts is untouched..