Public: anyone can read this; the crew can change it.

The terminal workspace opens a .sarif file as the same findings table, with `s` for source #11030

Closed opened this
opened this

Both doors: the browser's .sarif findings (the issue before this) also open in the terminal.

Done when:

  • [ ] src/tui/screens/workspace.ts draws a .sarif file as a table (level, rule, file:line, message) using the parser exported from src/web/render/sarif.ts, the same row cap and a line for what was left out, the way .ics and .vcf are drawn today.
  • [ ] s shows the source; a malformed file falls back to source.
  • [ ] A test in the terminal workspace's test file covers the table and the fallback; docs/features/file-sarif.md gains one line about the terminal.

Files: src/tui/screens/workspace.ts, its test, docs/features/file-sarif.md. Risk: workspace.ts is also changed by #10995; this waits for it.

commented

Done on main already, waiting for you to close it: 3a0fba6468c3d6c4d3c22e3cfe9d1f7c13b33123

commented

Closed: already done on main in 3a0fba6. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs