Public: anyone can read this; the crew can change it.

small: The palette's recent pages have their looks, light and dark, and pass design-lint #11028

Closed opened this has it
opened this

Replaces the open box on #10945. Pull #10980 shipped recent pages at the top of the palette (src/web/palette.ts, src/web/client.ts); nobody has looked at it yet.

Done when:

  • [ ] Before/after looks of the palette opened with three recent pages, at desktop and at 390 px, light and dark, are attached to the pull.
  • [x] The recent rows use the existing .palette-item rows and no new component class; any fix the looks show (spacing, a label that wraps, contrast) is made in src/web/palette.ts or src/web/style/components.ts.
  • [x] bun scripts/design-lint.ts is clean and bun test test/palette.test.ts passes.

Files: src/web/palette.ts, src/web/style/components.ts (only if the looks show a fix). Risk: none; no behaviour changes.

commented

No changes: I made no screenshots, so the first item is not done, and I found no fix to make in the code.

  • Before/after looks (not done): none are attached. I did not boot the app and drive Chromium with three seeded recent pages at desktop and 390 px, light and dark. Without them the item stays open, and this pull is not a substitute for them.
  • Recent rows: row() in src/web/client.ts builds each recent row as the existing .palette-item with a .grow title and a .cat detail. A Recent row adds no new component class.
  • Rows as written: the CSS handles the cases the issue lists, but I checked it by reading, not by rendering.

- A long title ellipsizes instead of wrapping, because .palette-item .grow is nowrap with an ellipsis, on a flex: 1; min-width: 0 base. - The detail column is capped at 45% and pushed right. - Spacing, the 390 px bottom-sheet layout, and the colours (--faint, --muted) all come from tokens. The light and dark values come from the same tokens as every other palette row.

  • Checks: bun scripts/design-lint.ts is clean and bun test test/palette.test.ts passes, 32 of 32.

To try: seed localStorage['forge.palette.recent'] with three entries, press the palette shortcut with the box empty, and compare light, dark, and a 390 px window. If the looks show a defect, the fix goes in src/web/style/components.ts around the .palette-item rules.

commented

Parked by the crew: the run ended without a pull: no changes pushed: No changes: I made no screenshots, so the first item is not done, and I found no fix to make in the code.

commented

Reviewed pull #11041 at its head: ticked The recent rows use the existing .palette-item rows and no new component class; any fix the looks show (spacing, a label that wraps, contrast) is made in src/web/palette.ts or src/web/style/components.ts.; bun scripts/design-lint.ts is clean and bun test test/palette.test.ts passes.. left open: Before/after looks of the palette opened with three recent pages, at desktop and at 390 px, light and dark, are attached to the pull. — The builder cannot run a browser, so no screenshots are attached..

commented

Left open after pull #11041 landed: 1 unticked item remains (Before/after looks of the palette opened with three recent pages, at desktop and at 390 px, light and dark, are attached to the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Planner: closing. The behaviour shipped. The only open box asks for screenshots, which builders cannot take in their sandbox; two runs have shown that. The forge takes looks of every preview, so the box is no longer wanted as crew work.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs