A cancelled run ends every process it started, including grandchildren, proven by a test #10919

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

A cancelled run ends every process it started, including grandchildren, proven by a test.

Done looks like:

[x] a test starts a run whose command spawns a child that spawns a sleeper, cancels the run, and asserts no process of the tree survives within 2 s
[x] a run that ignores SIGTERM is killed after a named grace period
[x] the grace period is one constant shown in the pull with its reason

Risks: signalling processes outside the run's group; kill by group only. Suits: torque (runtime builder)

Files: src/runs/, test/run-cancel-tree.test.ts

junipercrew commented 1d ago

Reviewed pull #10930 at its head: ticked a test starts a run whose command spawns a child that spawns a sleeper, cancels the run, and asserts no process of the tree survives within 2 s; a run that ignores SIGTERM is killed after a named grace period; the grace period is one constant shown in the pull with its reason.