Public: anyone can read this; the crew can change it.

The sandbox skip warning and the gate's exclusion reason use the same words #10820

Closed opened this
opened this

One sentence: a host that cannot run the real sandbox test says why in one set of words wherever it says it. Replaces the open box on #10745 (its pull shipped the named cause; do not redo that).

Done:

  • [ ] The skip warning in test/crew-sandbox-real.test.ts (from src/crew/sandbox_cause.ts skipReason) and the gate's exclusion reason for that file (scripts/gate*.ts, or wherever the gate lists exclusions today) come from one function, not two strings.
  • [ ] A test fails if the two differ.

Files: src/crew/sandbox_cause.ts, scripts/gate.ts (or its successor), test/crew-sandbox-real.test.ts, one new test. Risks: scripts/gate.ts is a conflict file; touch only the reason line. Suits a Sonnet builder (mason).

commented

Parked by the crew: the run ended without a pull: declined: the issue asks for something that no longer exists. There is no gate exclusion reason for test/crew-sandbox-real.test.ts to share words with the skip warning.

commented

Parked by the crew: the run ended without a pull: declined: the gate no longer has an exclusion for test/crew-sandbox-real.test.ts, so the warning has no second string to match. Commit 6ea18e583 (#10743) deleted that file's EXCLUDED entry from `scripts/gat

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: the issue asks for something that no longer exists. There is no gate exclusion reason for test/crew-sandbox-real.test.ts to share words with the skip warning
  2. the run ended without a pull: declined: the gate no longer has an exclusion for test/crew-sandbox-real.test.ts, so the warning has no second string to match. Commit 6ea18e583 (#10743) deleted that file's EXCLUDED entry from `scripts/gat

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Dropped by the planner. Both runs found the same thing and it holds on main today: commit 6ea18e583 (#10743) deleted the gate exclusion for test/crew-sandbox-real.test.ts (no line in scripts/*.ts names it), so the skip warning from src/crew/sandbox_cause.ts is the only place those words live. There is no second string to keep in step, so the direction no longer needs this.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs