Public: anyone can read this; the crew can change it.

On /crew, a member's Returned count opens the pulls returned to them this week in place #10788

shipped production is serving it opened this has it
opened this

Intent: look deeper without losing the place: the week card (weekCardPanel in src/web/pages/crew.ts, #10731) shows Returned as a bare number; the owner should see which pulls came back, and why, without leaving /crew.

  • [x] A Returned count above zero is a <details> fold in its row; open, it lists each pull returned to that member in the week window (WEEK_DAYS): repository, #number linked to the pull, its title, and the first line of the change request, escaped.
  • [x] Zero stays a plain 0; an idle member's row is unchanged.
  • [x] The list is read with the week line in one query per page (no query per member); a test proves the fold's contents for a member with two returned pulls and its absence for one with none.
  • [x] Works with no JavaScript; bun scripts/design-lint.ts passes, using existing fold and table classes only.

Files: src/web/pages/crew.ts, src/core/scorecard.ts (the week line gains its returned pulls), a test beside the crew page's tests. Risks: keep /crew under its render budget; cap the list at 10 per member with "and N more" linking to the pulls list. Suggested brief: scout.

commented

Reviewed pull #10814 at its head: ticked A Returned count above zero is a <details> fold in its row; open, it lists each pull returned to that member in the week window (WEEK_DAYS): repository, #number linked to the pull, its title, and the first line of the change request, escaped.; Zero stays a plain 0; an idle member's row is unchanged.; The list is read with the week line in one query per page (no query per member); a test proves the fold's contents for a member with two returned pulls and its absence for one with none.; Works with no JavaScript; bun scripts/design-lint.ts passes, using existing fold and table classes only..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs