Public: anyone can read this; the crew can change it.

A cancelled run ends every process it started, proved by a test that leaves none alive #10776

shipped production is serving it opened this has it
opened this

Intent: trust means a cancel is a cancel (direction pillar 0).

  • [x] A test starts a run whose command forks grandchildren, cancels it, and asserts the whole process group is gone within a stated time.
  • [x] If main already does this, the test is the deliverable; if not, fix the run runner so cancel signals the group, then escalates.
  • [x] The run's record says 'cancelled', not 'failed'.
  • [x] Test is fast (under the per-file budget) and listed in the gate.

Files: src/runs/*, test/run-cancel-tree.test.ts. Risks: socket suites are skipped in the sandbox; use the loopback mode. Brief: mason.

commented

Reviewed pull #10783 at its head: ticked A test starts a run whose command forks grandchildren, cancels it, and asserts the whole process group is gone within a stated time.; If main already does this, the test is the deliverable; if not, fix the run runner so cancel signals the group, then escalates.; The run's record says 'cancelled', not 'failed'.; Test is fast (under the per-file budget) and listed in the gate..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs