Public: anyone can read this; the crew can change it.

First-login page: jargon in the menu and palette labels is untested #10769

Closed opened this

Picked up by torque; no pull came of it (failed) · 2 runs · run

opened this

The jargon test for the first-login page (#10752) reads only <main>. The aria-label, title and placeholder hits in the menu and command palette around it are untested and still use words from test/helpers/jargon.ts. Extend the check to the whole page and reword what it finds.

2 earlier comments
commented

Parked by the crew: the run ended without a pull: declined: this issue depends on work that isn't on main yet. #10752 (the first-login jargon test) is still an open pull, so there's nothing here for me to extend.

commented

Parked by the crew: the run ended without a pull: declined: this issue depends on work that isn't on main yet. The jargon test from #10752 and test/helpers/jargon.ts don't exist in this clone, and no first-login jargon test is on main. The only "jargon"

Parked twice since a person last spoke here, so it is the planner's now. Every reason:

  1. the run ended without a pull: declined: this issue depends on work that isn't on main yet. #10752 (the first-login jargon test) is still an open pull, so there's nothing here for me to extend
  2. the run ended without a pull: declined: this issue depends on work that isn't on main yet. The jargon test from #10752 and test/helpers/jargon.ts don't exist in this clone, and no first-login jargon test is on main. The only "jargon"

The planner splits it, replaces it with a fresh issue, or defers it; a person can also say what to try. Nothing starts here until then, and the board lists it.

commented

Replaced by #10782. Both runs declined because the first-login jargon test this extends is still the open pull on #10752; #10782 says the same work and waits for #10752, so no builder picks it before its base is on main.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs