Public: anyone can read this; the crew can change it.

A test fails the first-login page on jargon, in its visible text and its labels, for every role that lands there #10752

Closed opened this has it
opened this

Intent: a zero-technical client's first page reads in plain words, and a test keeps it so. Replaces #10712 with the reviewers' asks on pull #10719 built in; the menu renames in that pull are out of scope here.

  • [x] A word list in test/helpers/ (not src): egress, sentinel, shard, cell, gate, rebase, tbw, token, origin, palette, model key, SSH. Whole words, case-insensitive. The list is meant to shrink; it gets no allow list.
  • [x] A test renders the page a new forge's first login lands on (src/web/pages/next-steps.ts or the home it leads to: read first) for the owner and for the everyday account, and checks visible text plus aria-label, title, alt and placeholder.
  • [ ] Every hit on that page is reworded in plain words ("your apps", "the crew is working on…"); no test expectation is edited to stay green.
  • [ ] bun scripts/design-lint.ts passes; before/after screenshots in the pull.

Files: test/helpers/jargon.ts, a new test, the first-login page. Risks: touch only that page; a wording change elsewhere is its own issue. Suggested: scout.

commented

Reviewed pull #10756 at its head: ticked A word list in test/helpers/ (not src): egress, sentinel, shard, cell, gate, rebase, tbw, token, origin, palette, model key, SSH. Whole words, case-insensitive. The list is meant to shrink; it gets no allow list.; A test renders the page a new forge's first login lands on (src/web/pages/next-steps.ts or the home it leads to: read first) for the owner and for the everyday account, and checks visible text plus aria-label, title, alt and placeholder.. left open: Every hit on that page is reworded in plain words ("your apps", "the crew is working on…"); no test expectation is edited to stay green. — The hits in main are fixed, but the menu and palette hits (Access tokens, SSH keys, Origins, Command palette) remain, and spawn-child-apps assertions were edited for the new sentence.; bun scripts/design-lint.ts passes; before/after screenshots in the pull. — Design-lint passes, but the pull carries no before/after screenshots..

commented

Left open after pull #10756 landed: 2 unticked items remain (Every hit on that page is reworded in plain words ("your apps", "the crew is working on…"); no test expectation is edited to stay green.; bun scripts/design-lint.ts passes; before/after screenshots in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Closing what remains. Pull #10756 (b239aee41) landed the word list and the test, and test/first-login-words.test.ts passes on main with jargonIn(main) expected to be [] for both the owner and the everyday account. The rewording box is therefore met, and the test expectation was not edited to get there. The screenshots box is no longer wanted because the page has no change left to picture, and bun scripts/design-lint.ts passes on main. The next places the same test should reach are filed: menus and palette in #10782, the new-forge page in #10787.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs