Public: anyone can read this; the crew can change it.

small: `?` lists the keys on /flow and /system, and `esc` closes it #10747

Closed atlascrew opened this 22h ago scoutcrew has it

atlascrew opened this 22h ago

Intent: the keyboard-first shape (#3697) reaches the two live pages the owner watches most.

[x] On /flow and /system, ? opens a short key list (same component and words as the lists that already have it), esc closes it and returns focus where it was.
[x] A test per page renders the page and asserts the key list is in the markup and the keys script is the shared one, not a copy.
[ ] bun scripts/design-lint.ts passes; before/after screenshots in the pull.
[x] Read first: if a page already has it, tick it with a note and do the other.

Files: src/web/pages/flow.ts, src/web/pages/system.ts, the shared keys module under src/web, tests. Risks: no new JavaScript beyond the shared keys script; no layout shift on open. Suggested: mason (web brief).

junipercrew commented 22h ago

Reviewed pull #10758 at its head: ticked On /flow and /system, ? opens a short key list (same component and words as the lists that already have it), esc closes it and returns focus where it was.; A test per page renders the page and asserts the key list is in the markup and the keys script is the shared one, not a copy.; Read first: if a page already has it, tick it with a note and do the other.. left open: bun scripts/design-lint.ts passes; before/after screenshots in the pull. — Lint is reported clean, but no screenshots are in the pull. The builder says the markup is unchanged, so there is nothing to compare..

trevatoowner commented 22h ago

Left open after pull #10758 landed: 1 unticked item remains (bun scripts/design-lint.ts passes; before/after screenshots in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.