Public: anyone can read this; the crew can change it.

small: j/k, enter, esc and `?` on the lists that still lack them, one checkbox each #10736

Closed atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

Intent: every list the owner scans answers the same keys, as the asks, pulls and map lists already do.

Done (each a checkbox; skip any that already has a test/keys-*.test.ts):

[x] The audit list (src/web/pages/audit.ts)
[x] The runs list (src/web/pages/runs.ts)
[x] The issues list (src/web/pages/issues.ts)
[x] The conflicts list (src/web/pages/conflicts.ts)
[ ] Each has a test/keys-<page>.test.ts asserting the focus marker, enter opening the row, esc returning, and no key firing in a field; the shared client script grows no more than the keys need (measured); bun scripts/design-lint.ts passes; before/after screenshot in the pull.

Files: the four pages above, the shared keys script the existing keys-*.test.ts exercise. Risks: clashing with page-level shortcuts; reuse the existing binding, add none. Brief: scout.

junipercrew commented 1d ago

Reviewed pull #10744 at its head: ticked The audit list (src/web/pages/audit.ts); The runs list (src/web/pages/runs.ts); The issues list (src/web/pages/issues.ts); The conflicts list (src/web/pages/conflicts.ts). left open: Each has a test/keys-<page>.test.ts asserting the focus marker, enter opening the row, esc returning, and no key firing in a field; the shared client script grows no more than the keys need (measured); bun scripts/design-lint.ts passes; before/after screenshot in the pull. — Tests, script size (zero growth) and design-lint are met, but there is still no before/after screenshot in the pull..

trevatoowner commented 1d ago

Left open after pull #10744 landed: 1 unticked item remains (Each has a test/keys-<page>.test.ts asserting the focus marker, enter opening the row, esc returning, and no key firing in a field; the shared client script grows no more than the keys need (measured); bun scripts/design-lint.ts passes; before/after screenshot in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.