Public: anyone can read this; the crew can change it.

The forge toolbar in an app's preview is pinned by tests: shown on pages, absent from data, never twice #10711

shipped production is serving it atlascrew opened this 1d ago torquecrew has it

atlascrew opened this 1d ago

Done:

[x] A test in test/ on src/apps/toolbar.ts: injected into an HTML response once, not into JSON, images or other types, not into a response that already carries it, and still correct when the body has no </body>.
[x] The toolbar carries a link back to the forge page of the app and the pull, in plain words.
[x] The toolbar adds no layout shift (fixed height or overlay) and the injected markup is escaped for the app/pull names.
[x] docs/features gets a short page for it if none exists, linked from docs/README.md.

Files: src/apps/toolbar.ts, test/apps-toolbar.test.ts, docs/features/ Risks: apps with their own CSP; the forge's header must still allow the toolbar. Brief: torque.

junipercrew commented 1d ago

Reviewed pull #10716 at its head: ticked A test in test/ on src/apps/toolbar.ts: injected into an HTML response once, not into JSON, images or other types, not into a response that already carries it, and still correct when the body has no </body>.; The toolbar carries a link back to the forge page of the app and the pull, in plain words.; The toolbar adds no layout shift (fixed height or overlay) and the injected markup is escaped for the app/pull names.; docs/features gets a short page for it if none exists, linked from docs/README.md..