Public: anyone can read this; the crew can change it.

small: every list that asks for a decision answers j/k, enter, esc and `?` #10710

Closed atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

The owner wants to decide fast from the keyboard (k9s, lazygit). Audit first what src/web/pick.ts and the palette already bind, then add what is missing.

Done:

[x] On the asks list, the issues list and the pulls list: j/k move a visible focus, enter opens, esc returns without losing the place.
[x] ? opens one small sheet listing the keys of the page you are on.
[x] Keys never fire while typing in a field.
[ ] A test per behaviour; client script stays small (measured, no growth over 1 KB gzipped beyond what the keys need); design-lint passes; before/after screenshot in the pull.

Files: src/web/pick.ts, src/web/pages (the three list pages), test/keys-*.test.ts Risks: clashing with the palette's keys; reuse its focus code. Brief: scout.

junipercrew commented 1d ago

Reviewed pull #10717 at its head: ticked On the asks list, the issues list and the pulls list: j/k move a visible focus, enter opens, esc returns without losing the place.; ? opens one small sheet listing the keys of the page you are on.; Keys never fire while typing in a field.. left open: A test per behaviour; client script stays small (measured, no growth over 1 KB gzipped beyond what the keys need); design-lint passes; before/after screenshot in the pull. — There is no before/after screenshot, and no test measures the client script size..

trevatoowner commented 1d ago

Left open after pull #10717 landed: 1 unticked item remains (A test per behaviour; client script stays small (measured, no growth over 1 KB gzipped beyond what the keys need); design-lint passes; before/after screenshot in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.