Public: anyone can read this; the crew can change it.
A pull can carry a look a person attached: an image at a stated width, beside the crew's own looks #1066
Sign in to join this conversation.
Public: anyone can read this; the crew can change it.
Replaces #791, parked twice:
Those checks went red on tests this change does not touch. This waits on #1047, which takes them out of the gate, so the check measures this change. Start from today's main. What done looks like is #791's, unchanged:
---
Why. "Done means reachable" asks every pull for looks at phone and desktop widths. The crew attaches its own looks through the preview environment. A person or an outside build agent has no way to put a picture on a pull: there is no attachment route, so looks end up described in words, with the files on someone's machine (see #790's first comment).
The job: a person attaches a look (an image taken at a stated width) to a pull, and it shows beside the crew's own looks.
Acceptance.
POST /api/v1/repos/:owner/:name/pulls/:number/lookstakes a PNG or JPEG of at most a few MB, a width label (phone or desktop) and one line saying what it shows. Only someone who can write the pull may post one. It is stored like the crew's looks and appears in the same strip on the change's page.Must not touch: the release workflow, the chart, other repositories.