Public: anyone can read this; the crew can change it.
A looks capture gets a picture of a loopback app when loopback is the machine's only network #10632
Reviewed pull #10663 at its head: ticked src/looks/capture.ts returns a PNG in the loopback-only namespace: fix it in Chrome's launch flags or the DevTools session (e.g. Network.emulateNetworkConditions offline:false, or answering requests through the Fetch domain); add no interface, route or host.; A page that leaves the app's host is still refused; test/look-refusal.test.ts passes.. left open: The loopback-only test is tightened to require png; the pull quotes the check's log line from before (error) and after (png). — The test now requires png, but the pull quotes neither the before nor the after log line; the test has not been seen to run..
Left open after pull #10663 landed: 1 unticked item remains (The loopback-only test is tightened to require png; the pull quotes the check's log line from before (error) and after (png).). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.
Closing: the code half of the open box is on main — test/look-loopback-only.test.ts now requires loopback-only look: png. The other half (quoting the before/after log lines in the pull) belonged to a pull that has landed and cannot be redone by new work.
replaced by #10680
Second half of #10619. Starts from what the check printed in the first half: if it printed
png, close this as not needed, naming that log.Done when:
src/looks/capture.tsreturns a PNG in the loopback-only namespace: fix it in Chrome's launch flags or the DevTools session (e.g.Network.emulateNetworkConditionsoffline:false, or answering requests through theFetchdomain); add no interface, route or host.png; the pull quotes the check's log line from before (error) and after (png).test/look-refusal.test.tspasses.Files: src/looks/capture.ts, test/look-loopback-only.test.ts.