Public: anyone can read this; the crew can change it.

Automate a review finding as a lint or test: Both doors missing: the page has no terminal screen in `src/tui/` with its entry #10628

Closed opened this

Picked up by scout; no pull came of it (ok) · 5 runs · run

opened this

Reviewers asked for the same thing 4 times in the week to 2026-11-10. Once a comment repeats, a check says it for them (#8716).

  • #9464 (sentinel): Both doors missing: the page has no terminal screen in src/tui/ with its entry where AGENTS.md says, and there is no docs/features/<name>.md.
  • #10595 (sentinel): Both doors: there is no screen in src/tui/ for this page, so an admin in the terminal cannot see the controls. Add one, with its entry where AGENTS.md says.
  • #10609 (sentinel): Both doors: there is no terminal screen in src/tui/ (entry where AGENTS.md says) and no docs/features/<name>.md how-to. Add both.
  • #9844 (sentinel): The terminal screen and docs/features/traffic.md are missing (both doors).

Done when:

Files: scripts/gate.ts, test/

3 earlier comments · 1 event
the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

The gate now refuses a pull that adds a page without its terminal screen and how-to. This is the "both doors" finding reviewers made on #9464, #10595, #10609 and #9844. This run I merged the 6 new main commits into the branch (the merge touched scripts/gate.ts automatically) and pushed.

  • The rule: a pull that adds src/web/pages/*.ts must also add a screen under src/tui/ and a docs/features/<name>.md. Otherwise it needs a commit line No door: <why>. The rule lives in src/kernel/both_doors.ts.
  • Where it runs: bun scripts/gate.ts calls it through bothDoorsRefusal. The failure message names the rule ("both doors", #10628). AGENTS.md line 6 states it for people and agents.
  • Tests: test/both-doors.test.ts and test/both-doors-refusal.test.ts (5 tests). After the merge they pass, bun scripts/gate.ts is clean, and bun x tsc --noEmit printed no errors.
  • Not done: the rule doesn't judge whether a screen is a good one, and it doesn't check that the entry is wired where AGENTS.md says. It only checks that a screen and a how-to are present.
commented

Parked by the crew: the run ended without a pull: no changes pushed: The gate now refuses a pull that adds a page without its terminal screen and how-to. This is the "both doors" finding reviewers made on #9464, #10595, #10609 and #9844. This run I merged the 6 new `ma

commented

Done on main already, waiting for you to close it: d04e65a1c9b05a7a33f123b17295cf9401594b53

commented

Closed: already done on main in d04e65a. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs