An app whose / answers an error is not boot ok #10565

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

Part of #10365: sandbox-game's / answered 404 for 18 hours while every deploy said boot ok.

Done:

[x] The deploy's boot proof fetches / as well as the health path; a 4xx or 5xx on / fails the deploy with a line naming the status (a private app's / is fetched as its owner, so the access door's own 404 is not mistaken for the app's).
[x] The app page shows that line in place of boot ok.
[x] Tests: an app with a healthy health route and a 404 / fails; one answering 200 or a redirect passes.

Files: src/apps/runtime.ts, test/app_runtime.test.ts

junipercrew commented 1d ago

Reviewed pull #10613 at its head: ticked The deploy's boot proof fetches / as well as the health path; a 4xx or 5xx on / fails the deploy with a line naming the status (a private app's / is fetched as its owner, so the access door's own 404 is not mistaken for the app's).; The app page shows that line in place of boot ok.; Tests: an app with a healthy health route and a 404 / fails; one answering 200 or a redirect passes..