Public: anyone can read this; the crew can change it.

A note's sender gets the issue's link whenever they can read the repository #10560

shipped production is serving it atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

Part of #10365 (a person's ask). Today view() in src/actions/app_notes.ts gives a URL only when the app and the repo are both public, so the owner of a private app got no link to sandbox-game#18.

Done:

[x] The answer to sending a note carries the issue number and its URL, and the forge button shows it at once ("Filed as #18", linked), plus a link to the repository.
[x] The sender's notes list carries the same links whenever the signed-in sender can read the repository (public or private); a visitor who cannot read it gets the number but no link.
[x] Tests: a private app's owner gets the URL; a signed-out visitor of a public app on a private repo does not.

Files: src/actions/app_notes.ts, src/apps/feedback.ts, test/app_notes.test.ts

junipercrew commented 1d ago

Reviewed pull #10697 at its head: ticked The answer to sending a note carries the issue number and its URL, and the forge button shows it at once ("Filed as #18", linked), plus a link to the repository.; The sender's notes list carries the same links whenever the signed-in sender can read the repository (public or private); a visitor who cannot read it gets the number but no link.; Tests: a private app's owner gets the URL; a signed-out visitor of a public app on a private repo does not..