Public: anyone can read this; the crew can change it.

The machines page shows one quiet line per disk, with the rated figures on open #10466

Closed opened this has it
opened this

Part of #10352, last third: make the disk health reachable.

Done when:

  • [ ] On GET /:owner/:name/settings/machines (src/web/pages/machines.ts), each machine lists its disks from diskSummary, one line each when healthy: model, written of rated TBW with its percentage, temperature. A <details> opens to every figure with its rating beside it (percentage used, spare vs threshold, media errors, minutes above warning/critical, power-on hours, unsafe shutdowns, projected TBW date).
  • [x] An alert shows its reasons in plain words with the badge the page already uses; no banner, no red when nothing is wrong. A behind-controller disk reads "behind a controller; SMART not visible". A model not in the catalog shows its numbers with "no spec sheet" in place of ratings. No reading yet says so in one line.
  • [x] Every value is escaped through html; writers only, as the page is today.
  • [ ] A test renders the page for a healthy, an alerting and a behind-controller disk and asserts the lines; bun scripts/design-lint.ts passes; before/after screenshots in the pull.

Files: src/web/pages/machines.ts, its test. Do not touch src/http/api.ts or src/http/server.ts (hot); the route already exists.

commented

Reviewed pull #10707 at its head: ticked An alert shows its reasons in plain words with the badge the page already uses; no banner, no red when nothing is wrong. A behind-controller disk reads "behind a controller; SMART not visible". A model not in the catalog shows its numbers with "no spec sheet" in place of ratings. No reading yet says so in one line.; Every value is escaped through html; writers only, as the page is today.. left open: A test renders the page for a healthy, an alerting and a behind-controller disk and asserts the lines; bun scripts/design-lint.ts passes; before/after screenshots in the pull. — Tests and lint are in, but no before/after screenshots are in the pull and none of the forge pictures at this head show the machines page..

commented

Left open after pull #10707 landed: 2 unticked items remain (On GET /:owner/:name/settings/machines (src/web/pages/machines.ts), each machine lists its disks from diskSummary, one line each when healthy: model, written of rated TBW with its percentage, temperature. A <details> opens to every figure with its rating beside it (percentage used, spare vs threshold, media errors, minutes above warning/critical, power-on hours, unsafe shutdowns, projected TBW date).; A test renders the page for a healthy, an alerting and a behind-controller disk and asserts the lines; bun scripts/design-lint.ts passes; before/after screenshots in the pull.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Both boxes are met on main: the disk lines render in src/web/pages/machines.ts (diskRow) and test/machines-disks.test.ts covers healthy, alerting, behind-controller and unknown-model disks. Only the screenshots were missing, which is not a box worth a run. Closing.

commented

Already done on main in 4946ee426: diskRow in src/web/pages/machines.ts and test/machines-disks.test.ts (healthy, alerting, behind-controller, unknown-model).

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs