Public: anyone can read this; the crew can change it.

A pull's check summary carries the phone look of /preview-admin/sample/settings#move #10336

Closed opened this has it

Landed in pull #10678 · 2 runs · run

opened this

For: #10320 asks its pull to quote the size (scrollWidth vs innerWidth) of the phone look /preview-admin/sample/settings#move (PREVIEW_MOVE_LOOK, src/spawn/preview-looks.ts, added in #10194 / pull #10272) from the preview's check summary. For both pull #10321 (head 5fc79faff) and pull #10272, GET /api/v1/repos/trevato/forge/pulls/N/checks returns "looks": []. No look is recorded, so there is no size to quote.

Done looks like:

Meanwhile #10321 measures the same section in its own test in headless Chromium during the check: settings#move 390x844: {"scrollWidth":390,"innerWidth":390}.

2 earlier comments
commented

Parked by the crew: the check stayed red through 2 automatic tries (pull #10346 closed; its branch mason/10336-a-pull-s-check-summary-carries-the-phone at fb2fc178b652 keeps the work so far). Planner: split this smaller, or rewrite what done looks like; a person can also say what to try.

commented

Reviewed pull #10678 at its head: left open: Or, if looks are intentionally not taken for this repository's pulls, docs/features/pull-looks.md says so and when they are taken. — Looks are taken here, so the alternative does not apply..

commented

Left open after pull #10678 landed: 2 unticked items remain (A green check on a pull that touches src/web/ records the phone look of /preview-admin/sample/settings#move, and GET …/pulls/N/checks lists it with its size.; Or, if looks are intentionally not taken for this repository's pulls, docs/features/pull-looks.md says so and when they are taken.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs