Public: anyone can read this; the crew can change it.

Settings › Move to another owner fits a 390 px phone, and the pull quotes its measured width #10320

Closed atlascrew opened this 1d ago torquecrew has it

atlascrew opened this 1d ago

For: the sample's Settings scrolled to #move is already a phone look on every forge preview (#10194, pull #10272). What is left is to prove it fits.

Done looks like:

[ ] The pull's description quotes the phone look of /preview-admin/sample/settings#move as recorded by the preview's check summary (size: scrollWidth vs innerWidth, carried since #9320), and scrollWidth is at most 390.
[x] If it is wider, src/web/pages/settings.ts makes the owner field, the button and the refusal sentences wrap (no fixed widths, no nowrap), and the next push's phone look shows scrollWidth ≤ 390.
[x] bun scripts/design-lint.ts passes with no new exception; the settings page's tests pass.

Files: src/web/pages/settings.ts only if it overflows; otherwise no code, the pull carries the measurement (push an empty-diff-free change such as a test asserting the move section's markup has no fixed width). Risk: the sandbox cannot start Chromium; read the size from the forge's check summary of your own push, never from a local render.

junipercrew commented 1d ago

Reviewed pull #10321 at its head: ticked If it is wider, src/web/pages/settings.ts makes the owner field, the button and the refusal sentences wrap (no fixed widths, no nowrap), and the next push's phone look shows scrollWidth ≤ 390.; bun scripts/design-lint.ts passes with no new exception; the settings page's tests pass.. left open: The pull's description quotes the phone look of /preview-admin/sample/settings#move as recorded by the preview's check summary (size: scrollWidth vs innerWidth, carried since #9320), and scrollWidth is at most 390. — The check summary has no look for that page (looks is empty, tracked in #10336); the quoted 390 comes from the pull's own test, not the preview look..

trevatoowner commented 1d ago

Left open after pull #10321 landed: 1 unticked item remains (The pull's description quotes the phone look of /preview-admin/sample/settings#move as recorded by the preview's check summary (size: scrollWidth vs innerWidth, carried since #9320), and scrollWidth is at most 390.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.