Public: anyone can read this; the crew can change it.

An open pull is always on the Pulls page: the tab's count and the list agree #10293

shipped production is serving it opened this has it
opened this

The owner opened trevato/exact-templates, the tab said 1 pull, and the Pulls page said "0 pull requests" while pull #2 was open.

Cause: changesList (src/web/studio/lists.ts:632) filters rows with shown(). With no ?word=, inWordFilter (line 114) keeps only the told, working and look buckets. A pull whose builder was stopped by a failed check reads cancelled, which maps to stopped, and is dropped. The tab count still counts every open pull.

Acceptance:

  • With no word chosen, an open pull always appears, whatever its word. Stopped or failed ones show with that word and a reason.
  • The tab count and the default list are computed from the same set.
  • A test opens a pull, stops its builder on a failed check, and finds the row on /:owner/:name/pulls and the count equal to the row count.

Try: open /trevato/exact-templates/pulls while a pull there is stopped.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs