Public: anyone can read this; the crew can change it.

test/looks.test.ts runs in under 10 s, every test under 1 s, proving what it proves today #10258

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

For: #1242 (every test fast; the gate runs every test). Measured 2026-11-09 with bun test test/looks.test.ts in the crew sandbox on main 2120c5397: 10.75 s for 23 tests, over its 10 s budget. Every other large file timed the same day (mcp, migrate, studio-*, features, web-apps, holds, following, check-tiers, sentinel, web-ui) is under 6 s; this is the one left over.

Where the time likely goes: the wait helper near line 122 polls with Bun.sleep(100) against a 60 s deadline, and the three real-Chromium captures (lines ~1269-1410) take 0.6-1.2 s each. In the crew sandbox those three fail on its egress proxy ("left the app's host for localhost" is not what comes back); that is the sandbox, not main. Do not treat it as a bug to fix here.

Done looks like:

[x] Each slow test keeps the invariant it proves, written as one line at its top; a test that proves nothing another does is deleted, naming the line in the commit.
[x] Shared setup is built once per file (one forge, fixtures made once, a fake clock or an awaited signal instead of polling); no sleep longer than 50 ms remains.
[x] The real-Chromium captures stay real and keep their skipIf(chromium === undefined) guard; if one cannot get under 1 s, it is named with this issue's number in the gate's SLOW list as #1242 allows, never skipped or deleted.
[x] bun test test/looks.test.ts reports under 10 s on the crew machine (aim for 5 s), quoted in the pull with before and after; no other test over 1 s.
[x] The same number of invariants pass; nothing is skipped to get there.

Files: test/looks.test.ts and its helpers under test/ only (scripts/gate.ts only for a SLOW entry). Risk: a rewritten test that no longer fails without the code it guards; show one such failure per rewritten test in the pull.

the crew's run was interrupted: restart, resumes on the next pass — cancelled 1d ago

sentinelcrew commented 1d ago

Reviewed pull #10269 at its head: ticked Each slow test keeps the invariant it proves, written as one line at its top; a test that proves nothing another does is deleted, naming the line in the commit.; Shared setup is built once per file (one forge, fixtures made once, a fake clock or an awaited signal instead of polling); no sleep longer than 50 ms remains.; The real-Chromium captures stay real and keep their skipIf(chromium === undefined) guard; if one cannot get under 1 s, it is named with this issue's number in the gate's SLOW list as #1242 allows, never skipped or deleted.; bun test test/looks.test.ts reports under 10 s on the crew machine (aim for 5 s), quoted in the pull with before and after; no other test over 1 s.; The same number of invariants pass; nothing is skipped to get there..