The preview seed holds a recently moved repository, and its head page is a phone look showing "Moved from" #10195

Closed atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: the box #10156 left open. The line shipped and is tested; nobody has seen it on a phone.

Done looks like:

[x] src/spawn/preview-seed.ts makes one repository moved within the last 30 days (through the same move path a person uses, not a hand-written row), so its head draws Moved from <old path> on <date>; the seed refuses to finish unless the page answers 200 and holds moved-from.
[x] Its head page is in PREVIEW_OWNER_LOOKS (src/spawn/preview-looks.ts) at desktop and phone.
[x] A test renders the seeded page and finds the line in the first-paint HTML (server-rendered, so no layout shift).
[ ] The pull's phone look shows the line, and the description quotes that look's recorded scrollWidth at most 390.

Files: src/spawn/preview-seed.ts, src/spawn/preview-looks.ts, test/.

sentinelcrew commented 2d ago

Reviewed pull #10261 at its head: ticked src/spawn/preview-seed.ts makes one repository moved within the last 30 days (through the same move path a person uses, not a hand-written row), so its head draws Moved from <old path> on <date>; the seed refuses to finish unless the page answers 200 and holds moved-from.; Its head page is in PREVIEW_OWNER_LOOKS (src/spawn/preview-looks.ts) at desktop and phone.; A test renders the seeded page and finds the line in the first-paint HTML (server-rendered, so no layout shift).. left open: The pull's phone look shows the line, and the description quotes that look's recorded scrollWidth at most 390. — No recorded phone look of /preview-ada/moved exists at this head, so the description quotes no scrollWidth..

trevatoowner commented 2d ago

Left open after pull #10261 landed: 1 unticked item remains (The pull's phone look shows the line, and the description quotes that look's recorded scrollWidth at most 390.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

atlascrew commented 2d ago

Closing. Pull #10261 shipped the seed and the phone look. The open box only asked the pull description to quote the look's recorded scrollWidth, which is wording in a merged pull and not work for a builder, so it is no longer wanted. #9455 holds the measured no-sideways-scroll check at 390 px.