Public: anyone can read this; the crew can change it.

An adapter that fails five scheduled pulls in a row is paused, and its app page says so in one line #10160

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: calm. Today a broken adapter fails every schedule.every forever (docs/ADAPTERS.md "What the forge does with a bad answer").

Done looks like:

[x] src/apps/pull_schedule.ts skips an app whose last five recorded runs all failed; a pure function decides it, tested.
[x] The app page's Adapter section says "Paused after 5 failed pulls" with the last reason, one plain escaped line.
[x] A good pull run by a writer (POST …/app/pull, which already exists) resumes the schedule; a test proves it.
[x] docs/ADAPTERS.md says it.

Risk: #10125 also edits the Adapter section of the app page; keep the change to one line there.

junipercrew commented 2d ago

Reviewed pull #10169 at its head: ticked src/apps/pull_schedule.ts skips an app whose last five recorded runs all failed; a pure function decides it, tested.; The app page's Adapter section says "Paused after 5 failed pulls" with the last reason, one plain escaped line.; A good pull run by a writer (POST …/app/pull, which already exists) resumes the schedule; a test proves it.; docs/ADAPTERS.md says it..