Public: anyone can read this; the crew can change it.

The repository page's "Moved from" line is escaped and wraps at 390px, proven by a test and a phone look #10156

Closed opened this has it
opened this

For: the box #10109 left open. The line shipped; this proves it holds on a phone.

Done looks like:

  • [x] A test renders a moved repository whose old path holds <b>&" and finds it escaped in the "Moved from" line.
  • [x] The line wraps (long owner/name breaks rather than widening the page); a test or the Chromium case asserts no sideways scroll at 390x844.
  • [ ] The pull carries a phone look of the repository page with the line; no layout shift (the line is server-rendered on first paint).
  • [x] bun scripts/design-lint.ts passes.

Files: src/web/pages/repo.ts, test/ (repo page). Risk: none beyond style; keep the line one plain muted line.

commented

Reviewed pull #10177 at its head: ticked A test renders a moved repository whose old path holds <b>&" and finds it escaped in the "Moved from" line.; The line wraps (long owner/name breaks rather than widening the page); a test or the Chromium case asserts no sideways scroll at 390x844.; bun scripts/design-lint.ts passes.. left open: The pull carries a phone look of the repository page with the line; no layout shift (the line is server-rendered on first paint). — No phone look is attached; agents cannot attach one, so a person must. The server-rendered first paint is tested..

commented

Left open after pull #10177 landed: 1 unticked item remains (The pull carries a phone look of the repository page with the line; no layout shift (the line is server-rendered on first paint).). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

Split: the shipped work stays. The open box (a phone look of the repository page with the line) is #10195, which seeds a moved repository so every preview takes that look.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs