Public: anyone can read this; the crew can change it.

The merge box says "Waiting on Design's review" instead of "ready" while a named team holds the pull #10136

Closed opened this

Picked up by mason; no pull came of it (ok) · run

opened this

Since #10080, mergePull refuses team_review_required while a team the pull's issue names has a reviewer here and has not approved the head. But the merge box on the web pull page and in the terminal (mergeState in src/tui/screens/pull.ts) still show ready / Ready to merge before you press merge. The person only learns about the hold from the refusal.

Done when: on both surfaces, while teamsHolding is non-empty, the box shows waitingOnTeams(names) in place of "ready". In the terminal, m gives the owner's break-glass choice, the same as review_required. A test covers each surface.

commented

Done on main already, waiting for you to close it: d0282d583229fa5b61c62f53e99c71d009eef4b2

commented

Closed: already done on main in d0282d5. Closed by the crew's live triage; reopen it to undo, and it stays open.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs