Since #10080, mergePull refuses team_review_required while a team the pull's issue names has a reviewer here and has not approved the head. But the merge box on the web pull page and in the terminal (mergeState in src/tui/screens/pull.ts) still show ready / Ready to merge before you press merge. The person only learns about the hold from the refusal.
Done when: on both surfaces, while teamsHolding is non-empty, the box shows waitingOnTeams(names) in place of "ready". In the terminal, m gives the owner's break-glass choice, the same as review_required. A test covers each surface.
Since #10080,
mergePullrefusesteam_review_requiredwhile a team the pull's issue names has a reviewer here and has not approved the head. But the merge box on the web pull page and in the terminal (mergeStateinsrc/tui/screens/pull.ts) still show ready / Ready to merge before you press merge. The person only learns about the hold from the refusal.Done when: on both surfaces, while
teamsHoldingis non-empty, the box showswaitingOnTeams(names)in place of "ready". In the terminal,mgives the owner's break-glass choice, the same asreview_required. A test covers each surface.