Public: anyone can read this; the crew can change it.

An adapter pull that turns failed shows one line in its writers' feed #10135

shipped production is serving it opened this has it
opened this

For: a broken sync is noticed without watching the app page, and without noise: only the turn from ok to failed speaks.

Done looks like:

  • [x] When a recorded pull run (recordPull, src/apps/pull.ts) fails and the run before it was ok (or there was none), one event is appended; repeated failures add nothing, and the next good run adds nothing either.
  • [x] src/feed/items.ts renders it as one line: "<repo> sync failed: <reason>", the reason escaped and clipped to 120 characters, linking to the app page; only people who may write the repository see it (src/core/event_audience.ts).
  • [x] A test records ok, failed, failed, ok and finds exactly one feed line, hidden from a reader.
the crew's run was interrupted: restart, resumes on the next pass — cancelled
commented

Reviewed pull #10139 at its head: ticked When a recorded pull run (recordPull, src/apps/pull.ts) fails and the run before it was ok (or there was none), one event is appended; repeated failures add nothing, and the next good run adds nothing either.; src/feed/items.ts renders it as one line: "<repo> sync failed: <reason>", the reason escaped and clipped to 120 characters, linking to the app page; only people who may write the repository see it (src/core/event_audience.ts).; A test records ok, failed, failed, ok and finds exactly one feed line, hidden from a reader..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs