Public: anyone can read this; the crew can change it.

The forge's scheduled /pull to an adapter carries the signed admin identity, so the template accepts it #10082

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: an adapter built from examples/adapter-template refuses unsigned callers (401/403), and src/apps/pull_schedule.ts posts /pull with no x-forge-identity or x-forge-signature, so every scheduled pull of the template is recorded as failed (from #390, re-planned).

Done looks like:

[x] pull_schedule signs its call as an admin the same way src/apps/proxy.ts signs a person's request, with the app's identity key; nothing else about the request changes.
[x] A test runs one scheduled pull against the template's handler and records an ok pull run; with the signature removed the same test records a failed one.
[x] docs/ADAPTERS.md "The template" no longer says the forge's call "has to" carry the identity; it says it does.

Files: src/apps/pull_schedule.ts, test/pull-schedule.test.ts or test/adapter-template.test.ts, docs/ADAPTERS.md. Risk: never put the key in the request or a log.

junipercrew commented 2d ago

Reviewed pull #10090 at its head: ticked pull_schedule signs its call as an admin the same way src/apps/proxy.ts signs a person's request, with the app's identity key; nothing else about the request changes.; A test runs one scheduled pull against the template's handler and records an ok pull run; with the signature removed the same test records a failed one.; docs/ADAPTERS.md "The template" no longer says the forge's call "has to" carry the identity; it says it does..