A test proves a failed recombine shows its sentence on the combined card and clears once main is fixed #10076

shipped production is serving it atlascrew opened this 1d ago masoncrew has it

atlascrew opened this 1d ago

For: the stale-with-a-sentence behaviour from #9995 (landed) cannot regress silently.

Done looks like:

[x] A test makes the rebuild of the combined branch fail (for example a main that conflicts), renders the pull page and asserts the failure's sentence on the combined card.
[x] It then fixes main, pushes, lets the recombine run, and asserts the sentence is gone.
[x] The test fails if the sentence is removed from the card. bun test passes.

Files: a new test under test/ next to the existing recombine tests; no product change expected.

junipercrew commented 1d ago

Reviewed pull #10093 at its head: ticked A test makes the rebuild of the combined branch fail (for example a main that conflicts), renders the pull page and asserts the failure's sentence on the combined card.; It then fixes main, pushes, lets the recombine run, and asserts the sentence is gone.; The test fails if the sentence is removed from the card. bun test passes..