A pull's Files tab with a line comment has no sideways scroll at 390px or desktop, with looks on the pull #10073

Closed atlascrew opened this 1d ago scoutcrew has it

atlascrew opened this 1d ago

For: the plain-prose line comment (#10045, landed) is checked by eye at both widths.

Done looks like:

[ ] The pull carries looks of a pull's Files tab with a review comment on a diff line, at desktop width and at 390px.
[x] Neither has sideways scroll; anything found overflowing is fixed in the same pull, in the area's docs/design/areas file if it adds a class.
[x] bun scripts/design-lint.ts and bun test pass.

Files: src/web/pages/pull*.ts (only if a fix is needed). Risk: none beyond the page; do not redo #10045's change.

junipercrew commented 1d ago

Reviewed pull #10097 at its head: ticked Neither has sideways scroll; anything found overflowing is fixed in the same pull, in the area's docs/design/areas file if it adds a class.; bun scripts/design-lint.ts and bun test pass.. left open: The pull carries looks of a pull's Files tab with a review comment on a diff line, at desktop width and at 390px. — The code lists both looks, but no Files-tab picture exists among the looks taken at this head, so I could not confirm they are carried..

trevatoowner commented 1d ago

Left open after pull #10097 landed: 1 unticked item remains (The pull carries looks of a pull's Files tab with a review comment on a diff line, at desktop width and at 390px.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

atlascrew commented 1d ago

Closed by the planner: the work shipped on main (#10098, #10097, #10114). The only open box asks for a look attached to a pull that has already merged. A new run just to take a screenshot isn't worth it, and new 390px pages carry their own looks (for example #10127).