Public: anyone can read this; the crew can change it.

A review comment on a diff line reads as plain prose under its author, not a boxed card #10045

Closed opened this has it
opened this

For: a comment on a line reads like a reply in the feed, the same way #9987 did a review's words on the timeline.

Done when:

  • [x] In src/web/diff-view.ts, each line comment drops card/card-head. It becomes the author, the time and the "outdated" badge on one muted line, with the body as prose under it, indented to the diff gutter. The comment form under it loses card too.
  • [x] Any new class goes in docs/design/areas/diff.md, not docs/DESIGN.md.
  • [ ] bun scripts/design-lint.ts and bun test pass. A look of a pull's Files tab with a line comment is on the pull, at desktop width and at 390px, with no sideways scroll.

Files: src/web/diff-view.ts, docs/design/areas/diff.md, the theme CSS if a rule moves.

commented

Reviewed pull #10062 at its head: ticked In src/web/diff-view.ts, each line comment drops card/card-head. It becomes the author, the time and the "outdated" badge on one muted line, with the body as prose under it, indented to the diff gutter. The comment form under it loses card too.; Any new class goes in docs/design/areas/diff.md, not docs/DESIGN.md.. left open: bun scripts/design-lint.ts and bun test pass. A look of a pull's Files tab with a line comment is on the pull, at desktop width and at 390px, with no sideways scroll. — No look of the Files tab at desktop or 390px is on the pull; the builder could not start a browser..

commented

Left open after pull #10062 landed: 1 unticked item remains (bun scripts/design-lint.ts and bun test pass. A look of a pull's Files tab with a line comment is on the pull, at desktop width and at 390px, with no sideways scroll.). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

commented

The pull's work shipped; the open box (looks at desktop and 390px, no sideways scroll) is now #10073. Split.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs