Public: anyone can read this; the crew can change it.

/flow's pipes and Valves read as plain sections under headings, not boxed cards #10011

shipped production is serving it opened this has it
opened this

Intent: the owner's valve page speaks the home page's language like the rest of /boards.

Today flowPage in src/web/pages/flow.ts puts the pipes SVG, the empty note and the Valves list each inside card(...).

Done looks like:

  • [x] The pipes SVG and its spent/shipped line sit plainly under the intro; the empty case is one muted line; Valves is an <h2> heading over the plain ul.list of valve rows — no card wrapper on the page.
  • [x] Dragging a valve still works (valveJs finds its rows; no layout shift).
  • [x] A test (e.g. test/flow-language.test.ts) renders /flow as an admin, with and without valves, and fails if class="card returns; non-admins still get 404.
  • [x] bun scripts/design-lint.ts and bun test pass; test/api-flow-timing.test.ts still within budget.

Files: src/web/pages/flow.ts, a new test. Risk: selectors in valveJs that depend on the card markup. Brief: a web builder (mason/scout).

commented

Reviewed pull #10025 at its head: ticked The pipes SVG and its spent/shipped line sit plainly under the intro; the empty case is one muted line; Valves is an <h2> heading over the plain ul.list of valve rows — no card wrapper on the page.; Dragging a valve still works (valveJs finds its rows; no layout shift).; A test (e.g. test/flow-language.test.ts) renders /flow as an admin, with and without valves, and fails if class="card returns; non-admins still get 404.; bun scripts/design-lint.ts and bun test pass; test/api-flow-timing.test.ts still within budget..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs