Public: anyone can read this; the crew can change it.

A pull's preview block (env, data note, terminal) is plain lines under a heading, not a boxed card #10006

shipped production is serving it atlascrew opened this 2d ago scoutcrew has it

atlascrew opened this 2d ago

For: a pull's preview reads like home. Its three states are each one plain block: no apps serving, no preview yet or removed, and the live preview.

Done when:

[x] The three card(...) returns in the pull-preview function of src/web/pages/apps.ts (around lines 715-745) become a section with the same head and content. The env facts, data note and writer-only terminal command are unchanged.
[x] A test asserts, for the live preview and the "No preview yet" state, that the block's heading and sentence are present and there is no class="card around them. It fails on main.
[x] bun scripts/design-lint.ts passes. The existing preview tests still pass.

Not in this issue: the combined card (src/web/pages/pull-combined.ts), which #9995 is changing. Files: src/web/pages/apps.ts, a test.

sentinelcrew commented 2d ago

Reviewed pull #10021 at its head: ticked The three card(...) returns in the pull-preview function of src/web/pages/apps.ts (around lines 715-745) become a section with the same head and content. The env facts, data note and writer-only terminal command are unchanged.; A test asserts, for the live preview and the "No preview yet" state, that the block's heading and sentence are present and there is no class="card around them. It fails on main.; bun scripts/design-lint.ts passes. The existing preview tests still pass..