Public: anyone can read this; the crew can change it.

A guest pull's "What happens next" reads as plain lines under a heading, not a boxed card #10004

shipped production is serving it opened this has it
opened this

For: calm by default. A stranger's pull says what waits for it in plain words where it belongs.

Done when:

  • [x] Both returns in src/web/pages/pull-guest.ts render a section with an h2 ("What happens next" / today's head) and plain paragraphs, without card(...). The guest-waits sentence, the wall lines and the "Approve this guest" form (same-origin POST, writers only) are unchanged.
  • [x] A test (test/pull-guest-language.test.ts, new) opens a stranger's pull page as a writer and as the author and asserts that the section has no class="card, the heading and sentence are present, and only the writer sees Approve. It fails on main.
  • [x] bun scripts/design-lint.ts passes. The existing guest tests still pass.

Files: src/web/pages/pull-guest.ts, test/pull-guest-language.test.ts (new).

commented

Reviewed pull #10013 at its head: ticked Both returns in src/web/pages/pull-guest.ts render a section with an h2 ("What happens next" / today's head) and plain paragraphs, without card(...). The guest-waits sentence, the wall lines and the "Approve this guest" form (same-origin POST, writers only) are unchanged.; A test (test/pull-guest-language.test.ts, new) opens a stranger's pull page as a writer and as the author and asserts that the section has no class="card, the heading and sentence are present, and only the writer sees Approve. It fails on main.; bun scripts/design-lint.ts passes. The existing guest tests still pass..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs