Public: anyone can read this; the crew can change it.

A date that lands on a weekend or a US federal holiday is flagged with the next business day, and moving it there is one tap #84

shipped production is serving it opened this has it

Landed in pull #95 · run

opened this

Intent: contracts roll a deadline that falls on a weekend or holiday to the next business day; the agent should see that in the meeting, not find out on Monday.

Today src/dates.ts knows weekends (isWeekend, addBusinessDays) but no holidays, and nothing flags a due date that falls on a non-business day.

Done looks like:

Files: src/dates.ts, src/deals.ts (view), src/pages/sheet.ts, src/pages/deal.ts, src/week.ts, src/mcp.ts, src/openapi.ts, tests, README.md, docs/TECHNICAL.md.

Risks: the sample deals may start showing flags; that is fine and true, but check the README walk still reads. Do not change dates already stored; only flag and offer.

Suggested: mason.

commented

Reviewed pull #95 at its head: ticked src/dates.ts computes US federal holidays for any year with no dependency and no table (fixed dates with their observed weekday, and the nth-weekday ones such as Thanksgiving), and exports isBusinessDay / nextBusinessDay.; addBusinessDays steps over those holidays as well as weekends, so a business-day deal counts them out; calendar-day deals are unchanged.; Every open date whose due day is not a business day is flagged where the date shows: its marker's sheet, the deal page row, This week, the API (deadlines[].nonBusinessDay with the suggested date) and MCP get_deal, saying e.g. "Sat, Nov 28 · not a business day · next is Mon, Nov 30".; On the sheet and the deal page, a "Move to Mon, Nov 30" button moves it through the existing moveDeadline with the reason "Rolled to the next business day", so the move is recorded, audited and drafts the usual date-changed notice for approval.; Tests: holidays for two years (incl. an observed one, e.g. July 4 on a Saturday), the business-day count skipping one, the flag in the page and the API, and the one-tap move recording its reason.; README says in one line what the flag means; docs/TECHNICAL.md names the field..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs