Public: anyone can read this; the crew can change it.

A wrong link or a removed deal lands on a deal-clock page that says what happened and links back to the clock, not a bare "not found" #69

shipped production is serving it opened this has it

Landed in pull #72 · run

opened this

Intent: in a sales meeting a stale link (a deal removed, a typo in the address bar) today shows the plain text "not found"; it should look like the product.

Done looks like:

Files: src/routes.ts, src/pages/refused.ts (or a new src/pages/missing.ts beside it), src/pages/layout.ts, src/server.test.ts. Risks: do not let the HTML 404 reach API clients; keep signed-out visitors from learning anything about deals. Brief fits: a builder.

commented

Reviewed pull #72 at its head: ticked An unknown page path answers 404 with the app's layout (header, styles), a heading "Nothing here", one sentence, and a link to the clock (or to Sign in when signed out).; A deal id that does not exist, or was removed, answers 404 on its page, its client timeline and its sheet with the same page saying "This deal is not here; it may have been removed", and never reveals whether the id ever existed to someone who may not read it.; A request that asks for JSON (paths under the API, or accept: application/json) still gets the JSON {error:"not_found"} it gets today.; The security headers (CSP, X-Content-Type-Options, Referrer-Policy) are on the 404 page; it passes bun scripts/design-lint.ts.; Tests: unknown path is 404 HTML with a link to /; a removed deal's page is 404 HTML; an API miss is still JSON..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs