Public: anyone can read this; the crew can change it.

Closed deals show days from contract to closing, and the year's total adds the average #293

shipped production is serving it opened this has it

Landed in pull #295 · run

opened this

Intent: in the sales meeting the agent wants to say "my deals close in 34 days on average"; the app has the dates already.

Done:

Files: a new src/pace.ts and test, src/pages for the closed list and totals, src/sample.ts, README.md.

Risks: the sample-deal change may disturb tests that count samples (#283 also edits the sample area; keep to adding rows).

Suggested: mason.

commented

Reviewed pull #295 at its head: ticked Each deal in the Closed list shows "Closed in N days" (contract date to the closing date marked done; fell-through deals are listed apart and excluded).; The year's totals block (see Commission and your year) adds "Average N days to close" and the fastest and slowest, over deals closed this year; with no closed deals it says so in words rather than NaN or 0.; The math lives in one small module (plain data in, plain data out) next to the existing figures code and is used by the page; no new dependency.; Sample deals include at least two closed ones so the figure shows on first boot.; Tests: average, rounding, empty year, fell-through excluded, rendering escapes and has no undefined/NaN; the leak and speed tests still pass.; README describes it in Commission and your year. No contract.json change..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs