Public: anyone can read this; the crew can change it.

A held reminder can come back on a day the agent picks, and shows on Today's reminders that morning #292

shipped production is serving it opened this has it

Landed in pull #299 · run

opened this

Intent: a realtor holds a draft because the timing is wrong ("after the appraisal comes back"); they want it to return on its own instead of being remembered.

Done:

Files: src/db.ts, src/hold.ts-area modules and src/reminders.ts, src/pages/review.ts, src/routes.ts, README.md, tests.

Risks: the review finished-screen copy (recent change #276) and the leak test over drafts must keep passing; keep clear of #287 (parties) and #290 (amend).

Suggested: mason.

commented

Reviewed pull #299 at its head: ticked Holding a draft on the review page optionally takes a "bring back on" date (today or later, within a year; validated at the boundary; same-origin checked; permit as for hold today). Without a date, hold behaves exactly as now.; On or after that date the draft is listed again under Today's reminders, marked "Back from hold", with its edited words intact. Before it, it stays out of the count and the list.; A held draft with a date shows "Returns Thu 14 Nov" wherever held drafts are shown; the review page's finished screen counts it correctly.; Stored in a new nullable column via a migration (pin file updated); existing held rows stay held with no date.; Tests: dated hold hidden before and shown on the day, undated unchanged, past/garbage date refused, foreign origin refused, migration keeps old rows.; README mentions it under reminders; no contract.json change..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs