Public: anyone can read this; the crew can change it.

Every drafted message for every sample deal is checked for leaks: no undefined, null, [object], unfilled braces, double spaces or a missing sign-off #270

shipped production is serving it opened this has it

Landed in pull #274 · run

opened this

Intent: a realtor reading Review in a meeting must never meet a half-filled message.

Done:

Files: src/reminders.ts, a new src/leaks.test.ts. Risks: none beyond wording changes breaking pinned sentences; update those tests deliberately and say so. Suits: any builder.

commented

Reviewed pull #274 at its head: ticked A test loads the sample deals and, for each draft from drafts(), statusDrafts(), checkinDrafts() and anniversaryDrafts() across every moment (before, day_of, late, moved), asserts subject and body contain none of: undefined, null, NaN, [object, {{, }}, a double space, an empty party name; and that the body ends with the agent sign-off.; The same run with a party that has no contact and a date with no time/place still passes.; Any leak found is fixed in src/reminders.ts; bun test passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs