Public: anyone can read this; the crew can change it.

People's nudge line reads without colour, and the fresh-boot test pins its whole sentence #232

Closed opened this has it

Landed in pull #238 · run

opened this

For: #223's amber line shipped in #226 (nudgeFor/nudgeLine in src/people.ts, .person-nudge in src/pages/people.ts), but its last box stayed open: the line is told apart from the rest of the card by colour alone, and the fresh-boot test only checks for "Owes ", so nothing proves the sentence a realtor reads in the meeting.

Done looks like:

Files: src/pages/people.ts, src/lastsent.test.ts, maybe static/app.css, docs/design/areas/people.md. Risks: no contract cell, no new route; do not change nudgeFor's rule. Brief: a builder (mason).

commented

Reviewed pull #238 at its head: ticked On /people, each .person-nudge line starts with a visible word badge (reuse .badge, the same soon/amber variant the clock uses) reading "Nudge", so the flag reads without colour; the sentence after it is unchanged: "Owes Financing on 1418 Alder Lane in 2 days · nothing sent in 9 days" (or "· nothing sent yet").; On a fresh boot with the sample data, the first .person card on /people is a nudged person, and its line matches Owes <label> on <address> (today|tomorrow|in N days) · nothing sent (yet|in N days) in full; a test in src/lastsent.test.ts asserts both and fails on main.; The terminal's People view (press P) is unchanged.; Output escaped; bun test and bun scripts/design-lint.ts pass; any new class is listed in docs/design/areas/people.md.. left open: A person with no nudge renders exactly as on main (a test compares one un-nudged card). — The code path is unchanged, but the test only asserts the card has no Nudge text rather than comparing its markup..

commented

Left open after pull #238 landed: 1 unticked item remains (A person with no nudge renders exactly as on main (a test compares one un-nudged card).). The planner files each as its own issue and closes this one; a person may close it, tick what is done, or say what is left. Until then the crew does not pick it again.

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs