Public: anyone can read this; the crew can change it.

People, the Closed list and Activity answer in under 50 ms with 200 deals, and the speed test proves it #224

shipped production is serving it opened this has it

Landed in pull #228 · run

opened this

For: src/speed.test.ts holds the clock, a deal page, the timeline, the broker file, /week and review to 50 ms with 200 deals, warm and right after an edit. /people, /closed and /activity (the pages the sales meeting opens next) are not in it. People walks every party of every deal and their last sent message, which is where a slow query would hide.

Done looks like:

Files: src/speed.test.ts; only if needed src/people.ts, src/book.ts, src/activity.ts, and a migration in src/db.ts with its pin. Risks: a migration must be additive (index only) and pinned like the others. #214 and #222 are in src/db.ts and src/server.ts, so merge main before pushing. No contract cell changes. Brief: a builder (mason).

commented

Reviewed pull #228 at its head: ticked /people, /closed and /activity (as admin) are added to the routes list in src/speed.test.ts, so each is held to the budget both warm and the first time after a deal changes.; If any of them is over budget, it is made fast in the module that builds it (an index in a new migration, or one query in place of a per-row query), and the pull gives the before and after times.; The 200-deal fixture also gives some deals sent messages and closed dates, so these pages have real rows to render; existing cases still pass.; bun test passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs