Public: anyone can read this; the crew can change it.

The clock's marker for a listing agreement that expires before closing says so in its own words, not "falls on or after closing" #202

shipped production is serving it opened this has it

Landed in pull #204 · run

opened this

For: #174 shipped the listing-expiry conflict everywhere, but on the clock the flagged marker's spoken label (aria-label in drawLane, src/pages/clock.ts:70) still appends " — falls on or after closing" to every flagged date. For the listing agreement that is backwards: the expiry falls before closing. A screen reader, or an agent hovering in the sales meeting, hears the wrong warning.

Done looks like:

Files: src/pages/clock.ts, src/order.ts, src/order.page.test.ts (or src/listing.test.ts). Risks: output stays escaped through escape; no layout change, no contract cell changes. Run bun scripts/design-lint.ts. Suggested: mason.

commented

Reviewed pull #204 at its head: ticked A flagged marker's label uses the conflict's own words from conflictLine in src/order.ts (or a short form derived from it there), so the Listing agreement expires marker on 9 Orchard Row says closing falls after the listing agreement expires, and a slipped contingency still says it falls on or after closing.; No new wording is invented in src/pages/clock.ts; the words live in src/order.ts beside conflictLine.; Tests: on a fresh boot the clock page's marker for 9 Orchard Row's listing expiry carries the listing words and not "falls on or after closing"; the existing Alder Lane test in src/order.page.test.ts still passes..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs