Public: anyone can read this; the crew can change it.

The sample deals carry inspection and walkthrough times and places, so the sales-meeting tour shows where the buyer has to be #190

shipped production is serving it opened this has it

Landed in pull #194 · run

opened this

Intent: the demo runs on sample data, and today no sample inspection or walkthrough has a time or place, so the feature from #180 is invisible in a sales meeting.

Done looks like:

Files: src/sample.ts, src/sample.test.ts, README.md. Risks: sample seeding must still never touch a real agent's deals; times must pass the same rule src/appointment.ts applies (07:00–20:00, quarter hour). Brief: a builder (mason).

commented

Reviewed pull #194 at its head: ticked In src/sample.ts, every sample deal with an open Inspection date gets a time (a quarter hour between 08:00 and 17:00) and the property address as its place; every one with an open Walkthrough gets a time and the address. Done dates may keep none.; The times are written in the same step that writes closing_time/closing_place for samples, and survive Restore the samples (/samples/restore) and the daily re-dating of samples.; The deal page, the client timeline and the .ics of a sample deal show them, with no change to any of those renderers.; README "A five-minute tour" points at one sample's inspection time in one sentence.; Tests in src/sample.test.ts: after seeding, each open sample inspection has a valid HH:MM on a quarter hour and a place; restoring keeps them; no non-inspection, non-walkthrough sample date has a time..

Sign in to join this conversation.

↑↓ navigate ↵ open ⌘↵ its app esc close

Keyboard shortcuts

Docs